search

libretro / RetroArch

Cross-platform, sophisticated frontend for the libretro API. Licensed GPLv3.
http://www.libretro.com
GNU General Public License v3.0
10.12k stars 1.82k forks source link

Retro Achievements broken for TurboGrafx CD games #9594

Open prataczak opened 4 years ago

prataczak commented 4 years ago

Description

With the latest stable (also tested nightly), Retro Achievements do not work for any of the TurboGrafx CD games, while a couple of them did work previously on RetroArch 1.7.8.

Buster Bros., Castlevania - Rondo of Blood (translated) Akumajou Dracula X - Chi no Rondo Steam Heart's Sylphia Ys - Book I & II

Regular TurboGrafx 16 games do not seem to be affected at all. Akumajou Dracula X, Castlevania: Rondo of Blood (translated), and Ys - Book I & II are all confirmed working on the previous stable version of RetroArch (1.7.8).

Environment information

orbea commented 4 years ago

Can you bisect this to the first bad commit?

prataczak commented 4 years ago

Not sure how to do that orbea... I know that, as mentioned previously, a couple of the games worked fine on version 1.7.8 (stable).

orbea commented 4 years ago

Here is some documentation.

https://git-scm.com/docs/git-bisect

The reality is that unless someone who can reproduce this issue bisects the issue and finds the commit(s) where this broke it will likely not get fixed anytime soon. I unfortunately can not test retroachievements so someone else will have to bisect it.

televandalist commented 4 years ago

I developed the sets for Buster Bros., Steam Hearts, and Sylphia... so it didn't take long to find out about this issue. I let Jamiras know about this a few days ago and he said that RetroArch is no longer hashing the cue files due to how error-prone they are. There will hopefully be a fix soon.

Jamiras commented 4 years ago

Caused by #9521. When checking the SEGA CD hash, the buffered cue file is overwritten. We've wanted a more stable hashing method for PCEngine CDs for a while and this issue has made it a priority. I'm travelling right now and will address it ASAP upon my return.