search

libretro / glsl-shaders

This repo is for glsl shaders converted by hand from libretro's common-shaders repo, since some don't play nicely with the cg2glsl script.
913 stars 222 forks source link

Missing GLSL shaders that are present in slang-shaders #309

Open TuxSH opened 11 months ago

TuxSH commented 11 months ago

Hello,

I've noticed that at least a few slangp shaders have no equivalent in this repo. I'm thinking about these ones in particular: https://github.com/libretro/slang-shaders/commit/93baa7ffac9fc7931b6c963eb7f16483c47eb2b2 .

Would it be possible to port them over (at least the simple colorspace-transform ones)?

Thanks

hizzlekizzle commented 11 months ago

Yes, it's very possible, I just haven't done it because it's a lot of files and I'm lazy.

TuxSH commented 11 months ago

For the ags-101 shader this should do it: https://gist.github.com/TuxSH/1d58807e1beb86646ac1ff112da908ef I think

I've noticed there is a bug where relative paths are not properly parsed in glslp: copy-pasting the entire shader folder to anywhere else results in no shader being detected, but pasting custom glslp shaders into the default dir does result in that shader showing up. This doesn't happen with vulkan shaders.

hizzlekizzle commented 11 months ago

That's weird. I haven't experienced that :/

Shader port looks good, nice work! You probably want to remove the version directive at the top of the file unless it specifically needs one for compatibility purposes, but otherwise, perfect. Care to throw it in a pull request to the main branch?

TuxSH commented 11 months ago

Sure, I will do it later :)