search

libretro / libretro-uae

PUAE libretro
GNU General Public License v2.0
117 stars 62 forks source link

ASPR stuck to NTSC #636

Closed Vweber73 closed 1 year ago

Vweber73 commented 1 year ago

Hi, I used to be able to easily swith between PAL and NTSC aspect ratios using the ASPR virtual key next to STBR, but now it seems stuck to NTSC, no matter what my video settings are. Did u overlook something?

Many thanks and best regards

sonninnos commented 1 year ago

Whoops, good catch. The type of the integer was changed, but not on the one referencing the variable as extern. Fix incoming ASAP.

Vweber73 commented 1 year ago

Many thanks!

Vweber73 commented 1 year ago

I could download the new core and now I can switch ok, thanks! Only thing. When CROP mode is on (full screen), swichting to NTSC ratio cuts the screen horizontally on top. Also, in CROP mode the status bar overlaps the Amiga screen instead of being below. I tried this on F/A 18 interceptor. Is it supposed to be that way?

sonninnos commented 1 year ago

I have no idea what you mean. FA18 behaves just as expected (as in centered) in every crop mode and pixel aspect ratio, since it does not use full PAL resolution. I see no weirdness in statusbar location either in any mode.

PAL resolutions (256+) will not work properly in NTSC aspect mode, since it will also use the NTSC resolution so that it looks like it is in real NTSC mode without changing speed, which can't fit full PAL height.

Vweber73 commented 1 year ago

What I mean is this: Screenshot_20231014_220326_RetroArch (AArch64) Screenshot_20231014_220315_RetroArch (AArch64)

Vweber73 commented 1 year ago

I think that's because I used "automatic PAL". Switching to "automatic NTSC" fixes it.

Vweber73 commented 1 year ago

I also have this overlap for the status bar Screenshot_20231014_224542_RetroArch (AArch64)

sonninnos commented 1 year ago

I tried the WHDLoad version which goes straight to the game instead of that Workbench screen, so there is no such issues there.

Clearly the screen is using 256 height for some reason even if it looks empty, therefore it can't fit the NTSC size, as I described. Running in real NTSC of course never can go over 240 height.

Statusbar is never below the image, but inside the image, so it is correct.

Vweber73 commented 1 year ago

Ok, thanks!