search

libretro / mgba

mGBA Game Boy Advance Emulator
https://mgba.io/
Mozilla Public License 2.0
70 stars 77 forks source link

Let GCC chose the proper march and mcpu flags for each Pi model #253

Closed vanfanel closed 2 years ago

vanfanel commented 2 years ago

Modern GCC provides the right flags for each Pi model, so we don't need a chunk of ifeqs for that. Also, fixed the rpi platform in general since there was a typo on the platform redefinition as unix.

MuPendulum commented 2 years ago

As far as I understand, native will not work for cross-compiling which is what most users will use and isn't Pi specific. mcpu should set both march and mtune according to the docs and you can add any extensions the Pi(s) supports that aren't enabled by default.

Your changes also need to be properly rebased.

metchebe commented 2 years ago

I agree, march or mcpu=native will not work when cross compiling. The previous platform=rpiX definitions worked well.

This should be reverted.

vanfanel commented 2 years ago

@twinaphex As per previous comments, please revert this.

endrift commented 2 years ago

There seem to be many changes lumped into one PR that may not want to be changed. Can you please make a PR to only revert the specific parts?

vanfanel commented 2 years ago

@endrift This PR re-adds the specific cflags, and improves how they are processed: https://github.com/libretro/mgba/pull/255

Please merge that one.