search

libretro / nestopia

Nestopia emulator with libretro interface
GNU General Public License v2.0
52 stars 46 forks source link

Fix source of netplay desyncs #84

Closed N7Alpha closed 8 months ago

N7Alpha commented 8 months ago

I accidently assassinated my first PR when I rebased on the upstream branch. In any case the desyncs still happened when I tested. This commit doesn't really differ from my first implementation I just fixed conflicts. Most of the code that needed to change was more or less the same thankfully it just got moved around.

carmiker commented 8 months ago

Sorry, I had to revert this as it broke old states. I think we can work around this in a way that doesn't break old states, but I don't have time to do it immediately.

N7Alpha commented 8 months ago

Sorry, I had to revert this as it broke old states. I think we can work around this in a way that doesn't break old states, but I don't have time to do it immediately.

I see yeah. I didn't even think about backwards compatibility, but it seems obvious now that you mention it. As long as you know about the issue and the root cause that's all that matters.

carmiker commented 8 months ago

I've taken your fix and allowed it to handle states that were created before the fix.

N7Alpha commented 8 months ago

I've taken your fix and allowed it to handle states that were created before the fix.

Awesome cool I’ll give it a try later today