search

libsdl-org / setup-sdl

GitHub action for providing SDL.
The Unlicense
24 stars 2 forks source link

SDL versions are hardcoded in src/constants.ts #5

Closed madebr closed 1 year ago

madebr commented 1 year ago

For now, all SDL releases are hardcoded in src/constants.ts. This means this repo needs an update after every SDL release.

Perhaps some GitHub api could be used to fetch all available releases?

madebr commented 1 year ago

The list is probably also too long since not all versions have good CMake support.

slouken commented 1 year ago

FYI, we have release-2.28.0 now. :)

madebr commented 1 year ago

I'm working now to get rid of it. Btw, did you remove the prerelease-3.0.0 tag?

slouken commented 1 year ago

We don't have a 3.0 pre-release, there's just main.

madebr commented 1 year ago

I meant this tag: https://github.com/libsdl-org/SDL/tree/prerelease-3.0.0. Looks like it is still there (I thought it was removed because it was not visible in the output of gh release list -R libsdl-or^CSDL -L 1000).

slouken commented 1 year ago

Oh, you shouldn't use that tag. It doesn't correspond to anything useful.

madebr commented 1 year ago

Versions are not embedded anymore since https://github.com/libsdl-org/setup-sdl/commit/f209f602ccff9007193bc3e685e22fa75ff2aa27