macOS: Check for macOS 10.10 using kCFCoreFoundationVersionNumber instead of AppKit

libusb / hidapi

A Simple cross-platform library for communicating with HID devices

https://libusb.info/hidapi/

Other

1.69k stars 399 forks source link

macOS: Check for macOS 10.10 using kCFCoreFoundationVersionNumber instead of AppKit #611

Closed mrpippy closed 1 year ago

mrpippy commented 1 year ago

Fixes: #587

Youw commented 1 year ago

This looks perfect. @nguyen-phillip can you confirm this fixes the issue in your environment?

nguyen-phillip commented 1 year ago

Yes, this should work -- the issue only manifests when linked against AppKit. Thanks!

Youw commented 1 year ago

should work

Would you be able to actually run and check? Thanks.

nguyen-phillip commented 1 year ago

We've patched out this version check entirely as we don't need to support macOS predating 10.10. However the minimal repro code for the (still open) Apple bug only has problems when AppKit is linked in. CoreFoundation and IOKit are fine.