search

libvips / pyvips

python binding for libvips using cffi
MIT License
649 stars 50 forks source link

Define a couple of declarations as opaque #464

Closed kleisauke closed 7 months ago

kleisauke commented 7 months ago

Resolves: #459.

kleisauke commented 7 months ago

This also fixes the warnings mentioned in https://github.com/libvips/pyvips/pull/47#issuecomment-395997024. I'm able to compile with CFLAGS="-Werror" locally:

$ CFLAGS="-Werror" CC=clang pip3 install . -v --break-system-packages
[...]
clang -shared -Werror build/temp.linux-x86_64-cpython-312/build/temp.linux-x86_64-cpython-312/_libvips.o -L/usr/lib64 -lvips -lgio-2.0 -lgobject-2.0 -lglib-2.0 -o build/lib.linux-x86_64-cpython-312/_libvips.abi3.so
installing to build/bdist.linux-x86_64/wheel
[...]
Successfully built pyvips
Installing collected packages: pyvips
Successfully installed pyvips-2.2.3
$ python -c "import pyvips; import _libvips; assert _libvips.lib.vips_version(0) == 8; print(pyvips.API_mode)"
True

Any testing on macOS would be very helpful.

pasqualesalza commented 7 months ago

I confirm this works on my macOS 14.4.1!

jcupitt commented 7 months ago

I made v2.2.3 including this fix, thank you Kleis.

I'll try to look again at your nice setuptools replacement for a v3 pyvips.