Broken images on some pages (links to root directory rather than assets)

life-itself / web3

Making sense of web3 & crypto. Introduction to key concepts and ideas. Rigorous, constructive analysis of key claims pro and con. A look at the deeper hopes and aspirations.

https://web3.lifeitself.org/

Creative Commons Zero v1.0 Universal

1.74k stars 193 forks source link

Broken images on some pages (links to root directory rather than assets) #219

Closed rufuspollock closed 1 year ago

rufuspollock commented 1 year ago

See e.g. https://web3.lifeitself.org/notes/emmett-2018-rewriting-story-human where images are broken

rufuspollock commented 1 year ago

@khalilcodes could you take a quick look to see what's causing this i.e. < 15m or so. (not necessarily fix if that is painful or if you can't work out the issue)

khalilcodes commented 1 year ago

@rufuspollock this is happering because there is no assets folder within site/content (it's at root). The repo uses the old https://github.com/flowershow/remark-wiki-link-plus package and it searches for images within the content folder.

A quick fix is symlinking the assets folder into site/content.

rufuspollock commented 1 year ago

@khalilcodes ok can you do that quick fix. Also can you open an issue about updating to Flowershow (and then we can estimate that).

khalilcodes commented 1 year ago

@rufuspollock Fixed in commit https://github.com/life-itself/web3/commit/41760f9634a55639a7a92a2c4bc2c663c9b7936b and new issue at https://github.com/life-itself/web3/issues/220

rufuspollock commented 1 year ago

FIXED.