liferay / generator-liferay-fragments

Yeoman generator for creating and maintaining Liferay Fragment projects
https://www.npmjs.com/package/generator-liferay-fragments
MIT License
30 stars 31 forks source link

Fragment assets should be preprocessed with a custom workflow #19

Closed p2kmgcl closed 3 years ago

p2kmgcl commented 5 years ago

Now we've got a valid workflow for developing fragments, we should start making it more customizable. We've talked about using SASS or event Babel for preprocessing fragments, but it would be even more useful that fragment creators could define customized processing while creating fragments.

main.js -> [Babel] -> main.js
styles.scss -> [SASS] -> styles.css
index.pug -> [Pug] -> index.html
[customCode.ts, otherCode.ts] -> [Typescript] -> main.js
styles.pcss -> [PostCSS] -> styles.css
index.html -> index.html

For this purpose we should:

trevor-ryan-burkholder commented 4 years ago

I am working on a further implementation I'm currently using Gulp to compile my SASS and TypeScript before the fragments get imported into Liferay. I'm going to be working on making this process more robust. I'll post some updates here in the future if others find this useful.

faragos commented 4 years ago

What's the state on this issue? It looks very promising and IMO this is one of the few things that are still missing.

p2kmgcl commented 4 years ago

Hey @faragos, although we are trying to keep track of missing functionality and bugs inside this repo, for the case that anyone wants to contribute to the project (:heart: @TBurk83), we work under Jira, and we still have no plans about this issue.

However, as I said, contributions are welcome :)

faragos commented 4 years ago

@TBurk83 How is your implementation going? Are you still working on it? Do you maybe need some help?😃

faragos commented 4 years ago

I implemented the SCSS part by myself for now and created a pull request. I'm waiting for any feedback 😃

p2kmgcl commented 3 years ago

Released here: https://github.com/liferay/generator-liferay-fragments/releases/tag/v1.8.0