liferay / liferay-ckeditor

Other
8 stars 49 forks source link

fix: LPS-165655 use Esc key to blur from codemirror #201

Closed dsanz closed 1 year ago

dsanz commented 1 year ago

In this PR we are allowing users to tab out the codemirror editor, which we use for the Source Mode. By default, this editor uses Tab key to indent content in the edition area, rather than swithcing focus.

We adopted the same solution codemirror6 proposes in this example, this time, using our codemirror5 plugin.

With this change, when editor is in source mode, pressing Esc key would make editor to lose focus, therefore, Tab key becomes available again.

A followup PR should ensure this info is made available to the user

dsanz commented 1 year ago

closing in favor of #202