search

liferay / liferay-frontend-projects

A monorepo containing assorted Frontend Infrastructure Team projects
Other
69 stars 68 forks source link

Enforce import of "atlas-variables", not "atlas" #59

Closed wincent closed 2 years ago

wincent commented 4 years ago

Came up in Slack again (sorry, private links) yesterday (previously, which references discussion in other places).

The most common pattern in liferay-portal (git grep 'import.+atlas') is to import just the variables. If you import 'atlas', you are probably doing it wrong, because it is effectively including Clay twice (once from the theme, then again in your local module):

kresimir-coko commented 2 years ago

There are no more usages of import 'atlas'