Closed JotaFan closed 1 year ago
:nerd_face: want some picky comments?
nerd_face want some picky comments?
Yes :spaghetti:
Hi – I entered the poetry ticket #6 and, though not yet versed on poetry at all, I wonder if this particular PR could just focus on the core "poetry-fication" itself, while avoiding all the other changes? As a general recommended practice, a given PR should only address a very specific aspect (and just opportunistically, but only with very minimal changes, some other things). Of course, standard/automated reformatting of code is also very desirable, but concrete changes for that purpose could probably be better addressed with subsequent/separate PRs? (cc @cparcerisas)
Hi – I entered the poetry ticket #6 and, though not yet versed on poetry at all, I wonder if this particular PR could just focus on the core "poetry-fication" itself, while avoiding all the other changes? As a general recommended practice, a given PR should only address a very specific aspect (and just opportunistically, but only with very minimal changes, some other things). Of course, standard/automated reformatting of code is also very desirable, but concrete changes for that purpose could probably be better addressed with subsequent/separate PRs? (cc @cparcerisas)
Agree, just droped the commits not having to do with the poetry usage
Change from setuptools to poetry. Applies conventions based on: https://open-science.vliz.be/conventions.html Closes #6