lightning-power-users / node-launcher

Easiest Bitcoin Lightning desktop app, for Windows, macOS, and Linux
MIT License
358 stars 67 forks source link

Node is private #105

Open eurtnl opened 5 years ago

eurtnl commented 5 years ago

Hi Pierre,

Thanks for Node Launcher, love this project! But i have a question: my node is private, what should i do to get it public reachable?

tiero commented 5 years ago

First, you should open on your router the port for the Lightning protocol (should be the 9735, I didn't look at the code) and allow inbound traffic in the computer firewall.

Last, you should add the public ip in lnd.conf file. If Mac should be ~/.lnd/lnd.conf and add/edit the following

externalip=<your ip here>
tlsextraip=<your ip here>

The second part can be automated I believe, the first is up to you.

PierreRochard commented 5 years ago

Integrating this into the Node Launcher will require more design choices than I anticipated, I'll punt this to the next major release

eurtnl commented 5 years ago

My ISP gave me an IPv6 address, could that be a problem?

BaalMarduk commented 5 years ago

After multiple test in lnd.conf it seems that listen= is override by something else. When I scan the open ports only 127.0.0.1 respond on port 9736. It wont respond to other ports set in lnd.conf Here are various IP and ports I tried:

listen=0.0.0.0:9737 listen=127.0.0.1:9737 listen=192.168.0.120:9737

screen shot 2019-01-19 at 11 58 25 am
BaalMarduk commented 5 years ago

After some investigation, I looked in the terminal log and their is a file dynamicaly created by Node Launcher: /var/folders/ns/msvmjd891_d33jfsj2dhp91m0000gn/T/tmpsi7ez45g-lnd.command that is loaded when LND is launching... and this file got a parametor that override the settings we put in the LND.conf file... I can see --listen=127.0.0.1:9736

screen shot 2019-01-19 at 1 31 05 pm
Freefromchainz commented 5 years ago

I noticed this aswell, I have a group that has the node launcher setup and they are running into the issue of broadcasting their public node id even after port forwarding on 9735 and removing firewalls blocking necessary ports. So this localhost@127.0.0.1:9736 setup or automated conf seems to be the issue.

On Sat, Jan 19, 2019, 11:35 AM Jonbros01 <notifications@github.com wrote:

After some investigation, I looked in the terminal log and their is a file dynamicaly created by Node Launcher: /var/folders/ns/msvmjd891_d33jfsj2dhp91m0000gn/T/tmpsi7ez45g-lnd.command that is loaded when LND is launching... and this file got a parametor that override the settings we put in the LND.conf file... I can see --listen= 127.0.0.1:9736 [image: screen shot 2019-01-19 at 1 31 05 pm] https://user-images.githubusercontent.com/31890680/51430831-82ac3100-1bee-11e9-8d66-4c1a44b45856.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/PierreRochard/node-launcher/issues/105#issuecomment-455804406, or mute the thread https://github.com/notifications/unsubscribe-auth/AH7rBOKmABeWB13tQStjbHub89j07_aBks5vE2V2gaJpZM4ZlVIU .

BaalMarduk commented 5 years ago

Basically I copy this line in a terminal window, removed the "--listen=127.0.0.1" parameter and press enter. My LN node is now public with the proper IP and ports (listed in the lnd.conf file) !! I still need after that to unlock your node with your password

willcl-ark commented 5 years ago

@Jonbros01 I believe this is the offending line:

https://github.com/PierreRochard/node-launcher/blob/master/node_launcher/node_set/lnd.py#L70

It seems likely that you might have (accidentally) clicked the testnet button when you (first) launched bitcoin using the launcher, causing the lnd.conf to consequently have testnet port settings written to it.

I don't know best practice to re-initialize your settings without losing any data, perhaps @PierreRochard can advise?

PierreRochard commented 5 years ago

Yikes, sorry about this guys!

I'll put together a guide for running a public node, there are changes in the next version of the node launcher that fix the testnet issue

whtstang commented 5 years ago

Has this been resolved? I'm still unable to run my node public.