Closed jkczyz closed 2 weeks ago
Attention: Patch coverage is 64.18605%
with 77 lines
in your changes missing coverage. Please review.
Project coverage is 89.62%. Comparing base (
2c1e828
) to head (7878801
). Report is 398 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
CI is still sad
Squashed fixups and fixed a no-std
test compilation failure.
Now that the
lightning
crate depends on thelightning_invoice
crate, the utility functions previously living in the latter can be implemented onChannelManager
. Additionally, the parameters are now moved to a struct in order to remove the increasingly combinatorial blow-up of methods.The new
Bolt11InvoiceParameters
is used to determine what values to set in the invoice. UsingNone
for any given parameter results in a reasonable the default or a behavior determined by theChannelManager
as detailed in the documentation.Fixes #3375