search

lightstep / lightstep-tracer-objc

The Lightstep distributed tracing library for Objective-C and Swift
https://lightstep.com
MIT License
11 stars 9 forks source link

Adjust to OTSpanContext changes and "cleanse" #9

Closed bhs closed 8 years ago

bhs commented 8 years ago

In this case, "cleanse" involves a bunch of Pods work to make the example reflect the reality of what a user of this pod will do. Also, wherever possible, LS* has been replaced by OT*. This includes the singleton, which should be an OT thing, not an LS thing.

As with other SpanContext changes, this PR cleans up some subtle cases in extract and leads to better separation of concerns around causal relationships between spans.

bcronin commented 8 years ago

As you noted, this is pretty hard to review given all the Pods related diffs :)

I added some comments on things that I'm not sure should be checked in. Other than that, I didn't notice anything that should get in the way of merging this.