search

lihenggui / blocker-general-rules

A repository for storing Blocker general rules
Apache License 2.0
36 stars 9 forks source link

Update info for WeChat NFC #15

Closed lihenggui closed 10 months ago

Mygod commented 10 months ago

Thanks! I took it from here, and I suppose this needs updating too? https://github.com/lihenggui/blocker-general-rules/blob/ef864eee56b11fc8e52ac6792609c0325bff6b0a/rules/en/general.json#L5804

lihenggui commented 10 months ago

Thanks! I took it from here, and I suppose this needs updating too?

https://github.com/lihenggui/blocker-general-rules/blob/ef864eee56b11fc8e52ac6792609c0325bff6b0a/rules/en/general.json#L5804

No, the description should match the component because you add a new component/library info.

Mygod commented 10 months ago

It was reused from here though? 👀

https://github.com/lihenggui/blocker-general-rules/blob/ef864eee56b11fc8e52ac6792609c0325bff6b0a/rules/en/general.json#L1515

lihenggui commented 10 months ago

Thanks! I took it from here, and I suppose this needs updating too?

https://github.com/lihenggui/blocker-general-rules/blob/ef864eee56b11fc8e52ac6792609c0325bff6b0a/rules/en/general.json#L5804

Correct, it needs updating. I missed that previously.