search

lihka1202 / pe

0 stars 0 forks source link

Sequence diagrams format not consistent #14

Open lihka1202 opened 1 year ago

lihka1202 commented 1 year ago

image.png

In this case, the diagram is colourized, however, in other cases, the diagram is not colourized. This is an issue of inconsistency in the DG

nus-se-bot commented 1 year ago

Team's Response

This is intended, as the sequence diagram is coloured so that it is coordinated with the architecture diagram as shown below.

The rest of the sequence diagrams in the DG such as in the commands section are not colour-coded as it may be confusing to the readers if the same colour is used to represent different classes in separate diagrams.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I believe that there isn't a need to colour code in the first place for 2 main reasons:

  1. The addition of colour doesn't aid that much in understanding the diagram, as most parts are distinctly separated from one another by the usage of boxes
  2. Not a standardized format of representing class diagrams and sequence diagrams.