search

lihka1202 / pe

0 stars 0 forks source link

Unnecessary Components #18

Open lihka1202 opened 1 year ago

lihka1202 commented 1 year ago

image.png

The PROS and CONS are not standardized for the various alternatives provided in the program.

And to a certain degree, they might be considered fairly unnecessary to the DG

soc-pe-bot commented 1 year ago

Team's Response

Not sure what you mean by PROS and CONS not being standardised. We believe that these details can add to the DG as it informs the developer reading the DG about our design choice of choosing to auto save after every change, rather than saving only on exit or with a save command. AB3 also follows a similar format when explaining design considerations, with suggested alternatives and weighing the pros and cons.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: What I refer to by standardization is the following:

These are the design considerations for the view function

image.png

These are the design considerations for the addStatement(userInput)

image.png

And the design considerations of saving and loading contain the PROs and CONs.

It would make sense to use a similar format for the design consideration for all the aspects of the program, by including a PROs and CONs aspect for all the design considerations, not specific ones. This brings about a serious inconsistency in the quality of Design Considerations in the Developer Guide.