likle / cwalk

Path library for C/C++. Cross-Platform for Linux, FreeBSD, Windows and MacOS. Supports UNIX and Windows path styles on those platforms.
https://likle.github.io/cwalk/
MIT License
250 stars 39 forks source link

Fix -Wsign-conversion warnings #8

Closed mupfdev closed 4 years ago

mupfdev commented 4 years ago

Fix implicit conversion changes signedness: 'long long' to 'size_t' (aka 'unsigned long long') warnings which are shown when -Wsign-conversion is enabled.

I noticed this when I compiled my own project with Clang's -Weverything option.

Best regards, Michael

codecov-commenter commented 4 years ago

Codecov Report

Merging #8 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #8   +/-   ##
=======================================
  Coverage   97.90%   97.90%           
=======================================
  Files           1        1           
  Lines         477      478    +1     
=======================================
+ Hits          467      468    +1     
  Misses         10       10           
Impacted Files Coverage Δ
src/cwalk.c 97.90% <100.00%> (+<0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f457e5b...617a7e1. Read the comment docs.

likle commented 4 years ago

Hi @mupfelofen-de ! Thanks a lot for your awesome fix!

mupfdev commented 4 years ago

Thanks for the merge. Appreciate it!