search

lilydjwg / nvchecker

New version checker for software releases
MIT License
425 stars 68 forks source link

feat: add netrc support #252

Closed blaggacao closed 6 months ago

blaggacao commented 6 months ago

due to the removal of the prefix key in the token configuration, this is a breaking change.

closes #251

I tested and confirmed that I could use my netrc file (withou using the keyfile) to access the relevant gitlab token and it detected correctly the version update.

lilydjwg commented 6 months ago

I don't think it's necessary to do a breaking change. You can strip the prefix until _ to query netrc.

Also, can you put custom github instance support in a separate commit?

blaggacao commented 6 months ago

@lilydjwg done so far, please feel free to review again and thanks for accepting this feature.