limetext / backend

Backend for LimeText
BSD 2-Clause "Simplified" License
538 stars 87 forks source link

Fix #118 watcher_test.go fails #119

Closed fmanno closed 8 years ago

fmanno commented 8 years ago

Check function of the Record was testing for equality with the relative path of the file to watch but the packages functions use the absolute path. Therefore the module wasn't getting loaded and the test was failing.

zoli commented 8 years ago

Thanks, this is related to what we discussed earlier here.

fmanno commented 8 years ago

Ah. Thanks for giving me the background and the related issue. I think it's then probably best to just get the absolute path from the relative path in the test instead of changing the Check method?

zoli commented 8 years ago

Yes, exactly.

fmanno commented 8 years ago

Great! I'll have a look tomorrow and post an update. Thanks

zoli commented 8 years ago

LGTM, Thanks.