limoka / DSP-Mods

An example how to add a custom model with your mesh and animations
MIT License
32 stars 10 forks source link

[ENHANCEMENT] - Don't apply foundations when placing a blueprint fails #46

Closed MartinJohns closed 2 years ago

MartinJohns commented 2 years ago

Describe the enhancement When placing blueprint it sometimes fails due to buildings in the way, or not enough space for the buildings (when moving to another latitude). In this cases the foundation is still applied, which (at least for me) is undesirable, especially when coloured. It would be a great enhancement if the foundation is only applied if the blueprint could be successfully placed.

To Reproduce Steps to reproduce the behavior:

  1. Create a blueprint containing foundations and a few buildings.
  2. Try to place the blueprint on an invalid location.

Expected behavior No foundation is applied when placing the blueprint fails.

hawkins353 commented 2 years ago

I found the same error. Locked up the whole game if apply foundations box is checked. Had to kill the game process in Task Manager.

limoka commented 2 years ago

I found the same error. Locked up the whole game if apply foundations box is checked. Had to kill the game process in Task Manager.

I'm fairly certain that your issue is not related to this Issue. Plus this has to be somehow related to latest game update, so please update all of your mods and if the issue persists open NEW issue.

limoka commented 2 years ago

Regarding this issue. I looked into it, and I believe it's not something I can easily add. Building conditions can easily be related to foundations. To fix that I paste foundations BEFORE main checks, so I can't know for sure if those will fail.

MartinJohns commented 2 years ago

Thanks for looking into it. :-)

hawkins353 commented 2 years ago

Thanks for looking into this. I saw there was an update to this mod today and this seemed to fix the issue.

Regards!

On Fri, Apr 22, 2022 at 12:02 PM kremnev8 @.***> wrote:

I found the same error. Locked up the whole game if apply foundations box is checked. Had to kill the game process in Task Manager.

I'm fairly certain that your issue is not related to this Issue. Plus this has to be somehow related to latest game update, so please update all of your mods and if the issue persists open NEW issue.

— Reply to this email directly, view it on GitHub https://github.com/kremnev8/DSP-Mods/issues/46#issuecomment-1106780434, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM7N4H3NSFT5SGQETL4ZGB3VGLZSVANCNFSM5TX5RYAA . You are receiving this because you commented.Message ID: @.***>

-- Regards, Christopher Hawkins