search

linagora / tmail-flutter

A multi-platform (Flutter) application for reading your emails, with your favorite devices, using the JMAP protocol!
GNU Affero General Public License v3.0
329 stars 75 forks source link

TF-3200 updated the menu options #3215

Closed florentos17 closed 1 month ago

florentos17 commented 1 month ago

i am tackling this issue

  1. i modified Open in New Tab to Open in new tab
  2. the order of the options is now changed to include Delete folder as the last option
github-actions[bot] commented 1 month ago

This PR has been deployed to https://linagora.github.io/tmail-flutter/3215.

hoangdat commented 1 month ago

Hi @chrismaster, please

Thank you

florentos17 commented 1 month ago

Hi @chrismaster, please

* run `dart run intl_generator:extract_to_arb --output-dir=./lib/l10n lib/main/localizations/app_localizations.dart` after changing something in app_localization

* please also change it in `Fr, En, It, Ru` too

Thank you

did you mean chrismaster or me ?

dab246 commented 1 month ago
  • as for the translations, i don't think any is needed since it is already all in lowercase letters for Fr, It and Ru (only the english version was featuring uppercase letters and needed change)

Also change it in the intl_en file

florentos17 commented 1 month ago

one more approval is required so that we could merge and close this work :)

dab246 commented 1 month ago

one more approval is required so that we could merge and close this work :)

@florentos17 Please rebase it

dab246 commented 1 month ago

@florentos17