TF-3264 Fix composer drag drop all modes - Githubissues

linagora / tmail-flutter

A multi-platform (Flutter) application for reading your emails, with your favorite devices, using the JMAP protocol!

GNU Affero General Public License v3.0

329 stars 75 forks source link

TF-3264 Fix composer drag drop all modes #3279

Closed tddang-linagora closed 1 day ago

tddang-linagora commented 1 week ago

Issue

3264

Root cause

Everytime ComposerView changes according to responsive size/display mode, all of MobileResponsiveContainerView/DesktopResponsiveContainerView/TabletResponsiveContainerView's childBuilder is rebuilt, causing HtmlEditor builds from scratch, including running initState method again.
However, ComposerController is alive throughout the rebuilds, causing the callbacks of HtmlEditor to break.

Dependency

https://github.com/linagora/html-editor-enhanced/pull/48

Resolved

https://github.com/user-attachments/assets/9337c68f-93ce-45bd-9ec2-26d1f4b078cc

github-actions[bot] commented 1 week ago

This PR has been deployed to https://linagora.github.io/tmail-flutter/3279.

dab246 commented 1 week ago

[x] It's still really buggy, we should investigate the html onDrag or onDrop events in composer.

https://github.com/user-attachments/assets/44b122bf-b2fd-4d43-85f9-8bb61bf267ab

tddang-linagora commented 1 week ago

It's still really buggy, we should investigate the html onDrag or onDrop events in composer.

Please check again.

dab246 commented 1 week ago

[x] It's not working perfectly yet. Error case: Open long email -> reply to it -> enter text -> zoom in/out 1-2 times -> then drag the file in

https://github.com/user-attachments/assets/e39c0563-5210-46e9-8e5c-c79222f2f25a

tddang-linagora commented 1 week ago

It's not working perfectly yet.

More fix added. Please check again.

dab246 commented 4 days ago

[x] Please check build CI failed & rebase it.