linagora / twake-on-matrix

A multi-platform (Flutter) application for connecting to Matrix - an open network for secure, decentralized communication, with your favorite devices.

GNU Affero General Public License v3.0

63 stars 18 forks source link

TW-1955: Create permission dialogs for contacts and images #1956

Closed Te-Z closed 4 months ago

Te-Z commented 4 months ago

Ticket

1955

Evolution of Google Privacy policies need dialog before asking contact and image permission

Resolved

Android:

https://github.com/user-attachments/assets/12e2caa7-3def-4bf3-8bb1-bd1f8fde6b7d

https://github.com/user-attachments/assets/6d41d3a4-bbcb-4eb6-aba6-496fdefb682b

IOS:

https://github.com/user-attachments/assets/0b40c790-4b6b-42e1-8264-5b33a7df0c39

https://github.com/user-attachments/assets/5db61025-517a-41c9-bbac-19c16c9e663d

https://github.com/user-attachments/assets/ecfe01d0-8f9c-4219-9254-1e032b1a6b35

github-actions[bot] commented 4 months ago

This PR has been deployed to https://linagora.github.io/twake-on-matrix/1956

nqhhdev commented 4 months ago

IMO:

Currently we have a warning banner for contact permission in contact tab. You should re-system the banner and dialog consistently
When we request contact permission:
- if permission is not Granted → show dialog
- if permission is Deny → don't need to show dialog, only show warning banner
For example:
- Install app Twake Chat and logged.
- Open contact tabs → permission is not Granted → show dialog then click Deny on Twake Dialog to close.
- Open again contact tabs → permission is Deny → Not show dialog, only show warning banner → continue actions

nqhhdev commented 4 months ago

One more thing:

When we display permission dialog first → click on actions (Deny or Allow) → close dialog and request native permission → show native dialog → continue