search

linagora / twake-on-matrix

A multi-platform (Flutter) application for connecting to Matrix - an open network for secure, decentralized communication, with your favorite devices.
GNU Affero General Public License v3.0
63 stars 18 forks source link

TW-1936: fix the share screen don't show up when sharing an image #1991

Closed sherlockvn closed 2 months ago

sherlockvn commented 3 months ago

Ticket

Related issue

1936

Solution

Outline the implemented solution, detailing the changes made and how they address the issue Change from go to push

Resolved

Attach screenshots or videos demonstrating the changes

https://github.com/user-attachments/assets/f98fb53c-e0f5-49da-94d6-edbc605fbea3

https://github.com/user-attachments/assets/97314f25-234b-434c-9977-cebcb064aa95

github-actions[bot] commented 3 months ago

This PR has been deployed to https://linagora.github.io/twake-on-matrix/1991

nqhhdev commented 3 months ago

I found an issue for this PR, reproduce steps:

https://github.com/user-attachments/assets/923a83c1-9c6a-437a-96f5-35e8a79d8c1e

sherlockvn commented 3 months ago

I found an issue for this PR, reproduce steps:

  • Open the app and go to the chat list
  • Open a chat and go to chat profile
  • Leave the app and share something (File, image, text)
  • Received share and open share screen
  • Send to another chat.

  • Can't open exactly chat and can't back to previous screen

    Simulator.Screen.Recording.-.iPhone.15.-.2024-08-08.at.17.13.24.mp4

https://github.com/user-attachments/assets/c40de08e-5907-4ed5-9d2b-a7d3f572dc3f

Te-Z commented 3 months ago

Found an other issue on android:

Expectation: when a file is shared only one instance of the app appear and there's no black screen

https://github.com/user-attachments/assets/4a92c71f-f9a5-4db3-9c39-0b907d5a03a7

sherlockvn commented 3 months ago

It doesn't happend to me. Can you delete all twake chat app first before test ? If it persist, please provide the information of your phone.

https://github.com/user-attachments/assets/1f0e8680-9048-45c2-9241-fbf13b6fe191

Found an other issue on android:

  • start typing something in search text field
  • leave the app and share something
  • the file is successfully shared
  • we now have two instances of twake chat (one with the sharing, the other one looks like the search screen)
  • when trying to go back on the first one there's a black screen, the only solution is to kill the app

Expectation: when a file is shared only one instance of the app appear and there's no black screen

screen-20240820-072605.mp4

nqhhdev commented 2 months ago

Failed for this case:

nqhhdev commented 2 months ago

Hi @sherlockvn I found an issue on Mobile (iOS and Android) related to your PR.

https://github.com/user-attachments/assets/4243463b-64c7-4ed8-b728-4b076a2440b3

https://github.com/user-attachments/assets/788a1aa5-1b76-4d75-803a-cd384a32e6e6

Tested on main branch

https://github.com/user-attachments/assets/c79da4e8-8c58-40b7-a27c-11eb282ad29a

sherlockvn commented 2 months ago

Fixed

Hi @sherlockvn I found an issue on Mobile (iOS and Android) related to your PR.

Screenrecorder-20240906-103340.mp4 Simulator.Screen.Recording.-.iPhone.15.-.2024-09-06.at.10.23.06.mp4

Tested on main branch

Simulator.Screen.Recording.-.iPhone.15.-.2024-09-06.at.10.42.35.mp4

https://github.com/user-attachments/assets/04e898dd-4bf9-49d8-ad2a-4906dfb7c2b1