linagora / twake-on-matrix

A multi-platform (Flutter) application for connecting to Matrix - an open network for secure, decentralized communication, with your favorite devices.

GNU Affero General Public License v3.0

63 stars 18 forks source link

Tw 2001: No previews for video #2004

Closed sherlockvn closed 2 months ago

sherlockvn commented 3 months ago

Ticket

2001

Root cause

We accidentally upload the original file instead of thumbnail file
We do not use correct file mimeType for thumbnail
Solution
Upload original file -> thumbnail file
add mimeType for thumbnail when sending video

Test recommendations

Recommendations for how to test this, or anything else you are worried about?

Send video, image in multiple platform to see if have thumbnail or not
Resolved

Attach screenshots or videos demonstrating the changes
Android:

https://github.com/user-attachments/assets/2bb4eded-8918-451a-b559-45113884a9f0

Web:

https://github.com/user-attachments/assets/d119b838-5c06-4ed0-828a-748a7c856334

IOS:

github-actions[bot] commented 3 months ago

This PR has been deployed to https://linagora.github.io/twake-on-matrix/2004

KhaledNjim commented 3 months ago

Worked well for mp4 videos but webm is not displayed properly

sherlockvn commented 3 months ago

Worked well for mp4 videos but webm is not displayed properly

this is expected behavior, because we can't display webp in the web platform