Closed tserg closed 10 months ago
There was a place where we wanted to use unwrap_or, in one PR a while back, but we couldn't (because that fn is only available in 2.4.0), but I can't remember where exactly that was. Can you? If not, no worries :)
Yes, previously we used it for an optional salt argument that is used for deploying the same contract multiple times within the same test, but we do not seem to need to do that anymore with Starknet Foundry.
This PR bumps Cairo to
v2.4.0
and links the access control and wadray libraries as dependencies.What was intentionally not done
assert_eq!
. There is no uniform support yet, so for example it currently does not work onContractAddress
orSpan<u64>
.Debug
andDisplay
traits. I think those are better done in a separate PR.There are also 2 failures in the CI that depend on other packages being fixed or supporting new features:
v2.4.0
.#[should_panic]
until Starknet Foundry supports something likeassert_not_emitted
. Thoughts?What else I did: