search

lindy-labs / opus_contracts

Opus Source Code
https://opus.money
Other
0 stars 0 forks source link

feat: use ByteArray for Yin name and symbol #565

Closed milancermak closed 8 months ago

milancermak commented 8 months ago

OZ v0.10.0 contracts now use ByteArray (pretty much a string) for their ERC20 contract. We should do that as well.

milancermak commented 8 months ago

Come to think of it, there's no benefit in doing so. Quite the contrary, it uses more operations and storage than a simple felt252. The ecosystem will have to support this due to historical reasons forever so IMO we're safe using it as well. Closing the ticket.

tserg commented 8 months ago

IMO, the increase in costs is okay since the main use cases will be off-chain.

I think the safer approach is to go with the consensus of the community, but I did not manage to find anything from a quick search of TG, Discord and the PR making the change in OZ. Maybe we can leave this open until right before launch to see if any consensus has developed?