search

linebender / glazier

Deprecated Rust Window Creation Library
Apache License 2.0
206 stars 32 forks source link

Fix Windows build. #153

Closed waywardmonkeys closed 1 year ago

waywardmonkeys commented 1 year ago

For some reason, this passed CI but is actually broken and needs winerror feature enabled. This was previously transitively enabled by dwrite and probably other features, but we removed the dwrite feature.

waywardmonkeys commented 1 year ago

@xStrom I'm pretty confused as to how #151 passed CI since this was apparently broken. :(

(Also confused how it got past me when I was testing the changes.)

waywardmonkeys commented 1 year ago

(Please just merge this once it is reviewed. I'm probably not awake.)

xStrom commented 1 year ago

Very interesting indeed. #151 fails locally for me too. I'll try to dig into the CI a bit to see what happened.