search

linebender / resvg

An SVG rendering library.
Apache License 2.0
2.84k stars 229 forks source link

Interested in fixing clippy lints? #788

Closed mattfbacon closed 4 months ago

mattfbacon commented 4 months ago

Would you be interested in a PR to fix the existing clippy lints? I wanted to ask before doing the work because sometimes people don't want it. As it is it makes it difficult to work on the project because there are over a hundred diagnostics including some deny-by-default lints that would seem to indicate serious issues.

For example:

Some of the diagnostics

LaurenzV commented 4 months ago

Afaik he doesn't like such PRs.

RazrFalcon commented 4 months ago

Nope: https://github.com/RazrFalcon/resvg/blob/master/.github/pull_request_template.md

I run clippy before a release anyway.