search

link2aws / link2aws.github.io

Get AWS console link from ARN
https://link2aws.github.io/
34 stars 20 forks source link

Feature: Add Amplify + Codepipeline service ARNs #39

Closed vboufleur closed 1 year ago

vboufleur commented 1 year ago

Hi!

This PR is for adding consoleLink URLs for Amplify build jobs ARNs and CodePipeline ARNs. I also updated package-lock.json to use the new format of NPM version 9.6.2.

I'm open to suggestions, if anything just let me know.

Thanks for the great work in this repo!

fxkr commented 1 year ago

Thank you very much for the contribution! I appreciate it.

As you can see above, the change to the package-lock.json caused the tests to fail. It was still a good idea to do it overall. But it needed some extra work. The reason for the failure was because we haven't updated the test environment in a while, and the NPM in the test environment was so old that it didn't work with the new lock file format. So I have added a commit to change the test environment to the latest one (docs).

Since the package-lock.json change is pretty impossible to review (nothing wrong with your change; that's just the way it is), I have also regenerated it once more for trust reasons. I do have an older NPM version than you (9.5, as shipped on Fedora 37) but oh well. I hope this suits your needs.

I have published all of the above as version 1.0.13.