fxkr
commented
6 months ago Thank you for the contribution. This is an interesting idea.
I apologize in advance that this will take me some time to review. I will need to carefully think about what input validation link2aws is doing and needs to do before we merge this, as this can have security implications (Open Redirect Abuse: link/link).
A few more review thoughts:
-
Privacy: this uses query parameters (
?arn=...), which will leak to the server (GitHub, so maybe not really an actual issue). For privacy reasons, it might be nice to use fragments instead (#...), which aren't sent to the server. But we can support both, and for this PR,?arn=would be fine. -
Browser compatibility: I wasn't sure, but
URLSearchParamsseems to be widely supported. So no problem. -
Also relevant: #8
Jeff-SearchPilot
This allows the user to pass in the arn as a url argument and be immediately redirected to it.