chavdar
commented
7 years ago Hi,
It looks like the change was to support unsigned long integers. Since Java does not support unsigned integers, the change stores the value in BigInteger so it can fit 64-bit unsigned numbers.
You are right, it's probably best to revert to the old logic for signed integers and use a BigInteger only when there is a signed long that cannot fit.
On Sun, Feb 5, 2017 at 12:18 AM, Bhashit notifications@github.com wrote:
Hello,
While setting things up Databus with MySQL this week, I came across a problem. This happens while running the MySQL example https://github.com/linkedin/databus/wiki/Databus-for-MySQL
I am using MySQL 5.7, but I think it's not relevant to this problem.
At this line in ORListener.java https://github.com/linkedin/databus/blob/master/databus2-relay/databus2-event-producer-or/src/main/java/com/linkedin/databus2/producers/ORListener.java#L615, the value of a LongLongColumn is being converted into a BigInteger. And it looks like that that was a fairly recent change. Earlier, it was taken as a Long value.
This seems to be causing problems with Avro serialization. For ex. the schema declares the id field as [ "long", "null" ], which gets mapped to a Long typed field in Person_V1 class https://github.com/linkedin/databus/blob/b775aeb2a0bd5448983607dc636c39f17227969e/databus2-example/databus2-example-person/src/main/java/com/linkedin/events/example/person/Person_V1.java#L32 .
Since the types don't match, we get an avro exception.
It's of course possible that I am missing something here. But could you please throw some light on this? Should I send a PR that reverts the mapping back to Long?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/linkedin/databus/issues/88, or mute the thread https://github.com/notifications/unsubscribe-auth/AA4sG3gTI6NaNV_1gtzkEJHSrJi9xEHBks5rZYXPgaJpZM4L3bhu .
769344359
dengshenyu
buptyzc
Hello,
While setting things up Databus with MySQL this week, I came across a problem. This happens while running the MySQL example
I am using MySQL 5.7, but I think it's not relevant to this problem.
At this line in ORListener.java, the value of a
LongLongColumnis being converted into aBigInteger. And it looks like that that was a fairly recent change. Earlier, it was taken as aLongvalue.This seems to be causing problems with Avro serialization. For ex. the schema declares the
idfield as[ "long", "null" ], which gets mapped to a Long typed field inPerson_V1class.Since the types don't match, we get an avro exception.
It's of course possible that I am missing something here. But could you please throw some light on this? Should I send a PR that reverts the mapping back to
Long?