search

linkedin / photon-ml

A scalable machine learning library on Apache Spark
Other
790 stars 185 forks source link

Change left to outer join when joining models and data #461

Closed yunboouyang closed 4 years ago

yunboouyang commented 4 years ago

trainModel function in RandomEffectCoordinate has a bug when prior models are involved. Since left join is used, any data with random effect ids not in prior models will be dropped. Therefore there is no model trained for that data.

This PR changes left join to outer join.