Browser instance is never destroyed

linkedtales / scrapedin

LinkedIn Scraper (currently working 2020)

Apache License 2.0

597 stars 174 forks source link

Browser instance is never destroyed #98

Open web-goddess opened 4 years ago

web-goddess commented 4 years ago

Running this locally and noticed that the process never finishes. Upon testing it looks like this is because the browser is never closed/destroyed. Is this a problem? Seems like a good enhancement would be a method to shut down the browser/ProfileScraper when you're done scraping.

rileyai-dev commented 4 years ago

I have added a websocket endpoint to manage your own browser with this PR: https://github.com/linkedtales/scrapedin/pull/106

Waiting for a merge...