search

linkwarden / browser-extension

Browser extension for Linkwarden
GNU Affero General Public License v3.0
146 stars 12 forks source link

Show a different icon when link is saved already #77

Closed m-GDEV closed 1 week ago

m-GDEV commented 1 week ago

Edit 1: I am new to typescript so if I'm not writing it properly please let me know.

These changes have been tested on Chrome and Firefox

This pull request adds support for the extension to show a different icon if the link has been saved already.

I'm new to this codebase so the way I implemented it may be naive. If it is please let me know.

Also the icon I added isn't perfect but it works, especially when it is so small. I wasn't sure if there was a vector graphic of the logo so I just edited the png I found on linkwarden/linkwarden.

crkos commented 1 week ago

Hello, thank you for taking your time to contribute!.

Does this resolve any issues open by any user if so, link it here please.

Although i appreciate it, It feels sudden when i get a PR like this.

You are free to contact me in discord, if you wanna work on certain feature and if it makes sense then you can implement it, so we can make sure it will be beneficial for the users.

Also no PR's on main, Fork dev then develop on top of that then pr to dev

m-GDEV commented 3 days ago

@crkos

Hello, thank you for your feedback.

I mostly created this PR since I thought it would be beneficial. #57 is also somewhat related.

Right now it takes multiple mouse clicks to check if the URL is saved already.

Where can I find your discord?

crkos commented 4 hours ago

Heres my disc: jordanhh

Sorry for delay