Closed AniJ98 closed 3 weeks ago
Hey @AniJ98, thanks for the contribution! Is there any particular reason this PR was closed? Otherwise we'd be happy to review and merge it.
The PR needed some changes. My team is currently reviewing it. I will reopen once they approve the changes.
š Description
This PR introduces comprehensive functionality and tests for Reserved IP Addresses in the Linodego client. The changes are necessary to provide robust support for managing Reserved IP addresses through the Linode API. The changes include:
Implementation of core Reserved IP operations:
Test coverage:
āļø How to Test
What are the steps to reproduce the issue or verify the changes?
To verify the changes related to Reserved IP functionality, follow these steps:
Ensure you have a valid Linode API token with the "can_reserve_ip" permission enabled.
Set up your environment:
export LINODE_TOKEN="your_token_here"
Additionally you need to set the following if you want to test it in a different environment:
Navigate to the test directory within the linodego project.
Update the LINODE_TOKEN in the Makefile: makefile
LINODE_TOKEN="your_token_here"
Run the tests using one of the following commands:
To run all integration tests:
make testint
To run only Reserved IP related tests:
go test -v ./integration -run TestReservedIPAddresses
To run a specific test:
go test -v ./integration -run TestReservedIPAddresses_EndToEndTest
Verify the test output for any failures or unexpected behavior.
Note:
if reserveIP != nil
because at the time of opening this PR, the user does not have permission to reserve an IP, so the response coming from the API is nil.