linsalrob / PhiSpy

Prediction of prophages from bacterial genomes
MIT License
70 stars 20 forks source link

conda installation failed #62

Closed dr-joe-wirth closed 1 year ago

dr-joe-wirth commented 1 year ago

I installed using conda install -c bioconda psispy. But running phispy produced the following error:

Traceback (most recent call last):                                                                                                                                         
  File "/scicomp/home-pure/uma2/miniconda3/envs/phispy/bin/phispy", line 7, in <module>                                                                                    
    from PhiSpy.py import main                                                                                                                                             
ModuleNotFoundError: No module named 'PhiSpy.py'; 'PhiSpy' is not a package

I fixed the error by modifying the phispy file:

These changes allowed the command phispy to work

linsalrob commented 1 year ago

This should not be necessary, and I don't know why you had to do this. All conda tests currently pass.

Please don't do this, as you will almost certainly break things.

linsalrob commented 1 year ago

I think the issue is the command. Try PhiSpy.py instead of phispy.

dr-joe-wirth commented 1 year ago

Nothing broke. It ran just fine after the fix I mentioned above as it was just telling the phispy file where to look. Plus main in the phispy file was not being invoked properly as sys.argv is a required argument.

If I recall correctly, I had tried running PhiSpy.py but it didn't run. This was last week though and I stopped thinking about it as soon as I posted this issue, so it is possible I am misremembering.

Thanks for following up on this!