search

linsomniac / python-memcached

A python memcached client library.
461 stars 201 forks source link

Please update setup setup.py for Python 3.5 and 3.6 #121

Open fizwit opened 7 years ago

mplanchard commented 7 years ago

FYI, updating setuptools to version 35.0.2 resolved the install issue for me. This package should probably specify a minimum required version of setuptools to avoid being unable to install it.

jasconius commented 7 years ago

Confirmed, if you upgrade setuptools to a sufficiently high version, this issue is bypassed.

timgraham commented 7 years ago

Do you know how to specify a minimum version of setuptools? I'm not sure if it's worth it. Based on your report, it sounds like the newer version of setuptools is only needed for Python 3.5 and later? What's the error?

mplanchard commented 7 years ago

In requirements.txt, which is parsed by setup.py, add setuptools>=35.0.2. It's been 5 months since I've had this problem, so I don't remember the exact error, but using a 3.5 virtual environment with a manually installed setuptools of less than 35 should consistently yield the problem. If I remember correctly, setup.py failed, and the package could not be installed.

If you wanted to specify the requirement only for Python 3.5 and up, you could add setuptools>=35.02;python_version>="3.4" to requirements.txt. See declaring platform specific dependencies in the setuptools docs.