linux-system-roles / network

An ansible role to configure networking
https://linux-system-roles.github.io/network/
BSD 3-Clause "New" or "Revised" License
238 stars 106 forks source link

feat: Support autoconnect_retries #737

Closed liangwen12year closed 1 month ago

liangwen12year commented 1 month ago

Enhancement: feat: Support autoconnect_retries

Reason: There is no fine-grained control over the number of retries for automatically reconnecting a network connection in the role. This limitation can be problematic for certain use cases where extending the retry process is critical, particularly in environments with unstable networks. Introduce support for the autoconnect_retries property in nm provider of network_connections variable. This feature allows users to configure how many times NetworkManager will attempt to reconnect a connection after a autoconnect failure, providing more control over network stability and performance.

Result:

Issue Tracker Tickets (Jira or BZ if any):

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.27%. Comparing base (89d7148) to head (0bda39e). Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
library/network_connections.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #737 +/- ## =========================================== + Coverage 20.40% 43.27% +22.87% =========================================== Files 10 12 +2 Lines 1485 3110 +1625 Branches 436 0 -436 =========================================== + Hits 303 1346 +1043 - Misses 1181 1764 +583 + Partials 1 0 -1 ``` | [Flag](https://app.codecov.io/gh/linux-system-roles/network/pull/737/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/linux-system-roles/network/pull/737/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

liangwen12year commented 1 month ago

[citest]

liangwen12year commented 1 month ago

[citest]

richm commented 1 month ago

Ignore the ansible-test output for now. We had to change the collection min version to 2.15, but it looks like ansible-test is using 2.14.

This handles the NM case - what about if you use network_state?

liangwen12year commented 1 month ago

Ignore the ansible-test output for now. We had to change the collection min version to 2.15, but it looks like ansible-test is using 2.14.

This handles the NM case - what about if you use network_state?

https://github.com/linux-system-roles/network/issues/735#issuecomment-2394068109, I suggested the user to try out the network_state to see if that will help with the situation.

spetrosi commented 1 month ago

[citest]

richm commented 1 month ago

@spetrosi still failing - from the logs, looks like some issue with the scp with the ssh key?

spetrosi commented 1 month ago

@spetrosi still failing - from the logs, looks like some issue with the scp with the ssh key?

I saw this, fixed in https://github.com/linux-system-roles/tft-tests/pull/52

spetrosi commented 1 month ago

[citest]