search

linux-system-roles / timesync

An ansible role which configures time synchronization
https://linux-system-roles.github.io/timesync/
MIT License
67 stars 43 forks source link

Add refclock support, used for VM using ptp clock of ESX #229

Closed Ofthestreet closed 11 months ago

Ofthestreet commented 11 months ago

Enhancement: Be able to configure chrony using the refclock parameter.

Reason: We configure the VM timesync using the Precision Clock feature of the ESX

Result: new variable in chrony.conf

Issue Tracker Tickets (Jira or BZ if any):

richm commented 11 months ago

can you use timesync_chrony_custom_settings for this without adding a parameter? https://github.com/linux-system-roles/timesync/blob/main/README.md#role-variables

Ofthestreet commented 11 months ago

You are completely right... Sorry

Le ven. 8 déc. 2023, 16:00, Richard Megginson @.***> a écrit :

can you use timesync_chrony_custom_settings for this without adding a parameter?

https://github.com/linux-system-roles/timesync/blob/main/README.md#role-variables

— Reply to this email directly, view it on GitHub https://github.com/linux-system-roles/timesync/pull/229#issuecomment-1847331365, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEOLNJLIEPDR7XEU2HYBZDYIMTP7AVCNFSM6AAAAABAMYHOK2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBXGMZTCMZWGU . You are receiving this because you authored the thread.Message ID: @.***>

richm commented 11 months ago

You are completely right... Sorry

No worries. Will you close this PR, or shall I?

Ofthestreet commented 11 months ago

This was my very first pull request ever done on GitHub, I was a bit prood ☺️

You can close it if you want unless I will do it on Monday

Le ven. 8 déc. 2023, 20:33, Richard Megginson @.***> a écrit :

You are completely right... Sorry

No worries. Will you close this PR, or shall I?

— Reply to this email directly, view it on GitHub https://github.com/linux-system-roles/timesync/pull/229#issuecomment-1847711028, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEOLNODDS2LGHVWK6IKDQLYINTPXAVCNFSM6AAAAABAMYHOK2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBXG4YTCMBSHA . You are receiving this because you authored the thread.Message ID: @.***>

richm commented 11 months ago

This was my very first pull request ever done on GitHub, I was a bit prood ☺️

cool :-)

You can close it if you want unless I will do it on Monday

ok - I'll leave it up for a while in case you want to show it to someone

Ofthestreet commented 11 months ago

I will detete my branch and this pull request, thanks @richm