chore: modify launch system-monitor by am dbus

linuxdeepin / dde-session-shell

dde-session-shell module

GNU General Public License v3.0

15 stars 55 forks source link

chore: modify launch system-monitor by am dbus #367

Closed yixinshark closed 7 months ago

yixinshark commented 7 months ago

launch system-monitor by am dbus

Log: launch system-monitor by am dbus Issue: https://github.com/linuxdeepin/developer-center/issues/8318 Influence: dock can display system-monitor app icon

deepin-ci-robot commented 7 months ago

deepin pr auto review

关键摘要:

使用 QDBusMessage 和 QDBusConnection 进行 DBus 调用时，没有处理可能的异常，例如 QDBusConnection::sessionBus() 可能因为没有正确初始化而返回 nullptr。
launchProcessByAM 函数中使用了 qDebug 和 qWarning，但在生产环境中，应该使用日志系统来记录错误信息。
launchProcessByAM 函数中的 QString("") 和 QStringList() 被硬编码，应该使用常量或者配置文件来管理这些值。

是否建议立即修改:

deepin-ci-robot commented 7 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: asterwyx, yixinshark

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[debian/deepin/OWNERS](https://github.com/linuxdeepin/dde-session-shell/blob/master/debian/deepin/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment