Closed kegechen closed 1 month ago
Doc Check bot :green_circle: Document Coverage Check Passed!
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: FeiWang1119, kegechen
The full list of commands accepted by this bot can be found here.
关键摘要:
updatePlayerIconSize()
函数调用后没有检查返回值,可能会导致未处理的初始化错误。updatePlayerIconSize()
函数调用可能依赖于sourceSizeChanged
信号,但当前的调用顺序没有反映这种依赖关系。是否建议立即修改:
只在初始化和 sourceSizeChanged 时更新图标大小 防止出现 dpr > 1.0 时未设置 sourceSize 的 item 在 updatePlayer 时图标一直放大 没有设置 sourceSize 会根据图片大小去 match dci 中的图标大小