fix: set correct QML_IMPORT_PATH

wineee commented 6 months ago

log: set QML env

deepin-ci-robot commented 6 months ago

deepin pr auto review

关键摘要:

在src/CMakeLists.txt中，QML_IMPORT_PATH变量被设置为包含多个路径，最后添加了一个无效的路径${PROJECT_BINARY_DIR}/qt/qml。这个改动没有实际的作用，应该移除。
greeter和treeland目录中的CMakeLists.txt文件中都有QML_IMPORT_PATH的设置，但是设置的路径已经被新的set_source_files_properties指令覆盖。应该删除这些多余的设置。
StackToplevelHelper.qml文件中移除了重复的import TreeLand.Protocols指令，这是一个好的改动，因为它减少了不必要的依赖和编译时间。
src/treeland/treeland-wallpaper/CMakeLists.txt文件中移除了QML_IMPORT_PATH的设置，这是一个正面的改动，因为它不再需要设置一个无效的路径。

合并相似的问题是否建议立即修改: 是

应该立即删除src/CMakeLists.txt和greeter、treeland目录中多余的QML_IMPORT_PATH设置。
确认移除StackToplevelHelper.qml文件中的重复导入是否符合代码规范和需求。
确认src/treeland/treeland-wallpaper/CMakeLists.txt文件中移除QML_IMPORT_PATH设置的改动是否符合项目需求。

deepin-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: justforlxz, wineee

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[debian/deepin/OWNERS](https://github.com/linuxdeepin/treeland/blob/master/debian/deepin/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

linuxdeepin / treeland

fix: set correct QML_IMPORT_PATH #274

deepin pr auto review