standard cron - Githubissues

linuxserver / docker-baseimage-fedora

GNU General Public License v3.0

4 stars 2 forks source link

standard cron #26

Closed nemchik closed 1 year ago

nemchik commented 1 year ago

Base image changes:

add packages needed for cron to be available
- Debian/Ubuntu don't have the option to use crond from busybox (it is not included) so they install cron through apt.
- Alpine already includes busybox with crond.
- Arch and Fedora will install busybox to provide crond.
if /defaults/crontabs/abc or /defaults/crontabs/root exist (in the downstream image) setup /config/crontabs/ for the user and import user crontabs to system
- downstream images should only ship abc crontab unless absolutely necessary (ex: rsnapshot needs root, cron mod sets up both so the user can do whatever they want)
if crontabs have been setup on system, run the cron service, otherwise sleep infinity (do nothing)

These should be safe to merge anytime as they don't actually do anything unless the downstream image (or the cron mod) include crontabs, or technically the user can mount /etc/crontabs/abc or /etc/crontabs/root to their image, but we should only ever ship /defaults/crontabs/* in downstream images so we're consistent in setting up the /config/crontabs/*

LinuxServer-CI commented 1 year ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/fedora/38-38-pkg-fa9200b6-dev-bb3bbb64f815bfff0fb0a0d753c347ced0f81b99-pr-26/index.html https://ci-tests.linuxserver.io/lspipepr/fedora/38-38-pkg-fa9200b6-dev-bb3bbb64f815bfff0fb0a0d753c347ced0f81b99-pr-26/shellcheck-result.xml	Tag	Passed
amd64-38-38-pkg-fa9200b6-dev-bb3bbb64f815bfff0fb0a0d753c347ced0f81b99-pr-26	✅
arm64v8-38-38-pkg-fa9200b6-dev-bb3bbb64f815bfff0fb0a0d753c347ced0f81b99-pr-26	✅

LinuxServer-CI commented 1 year ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/fedora/38-38-pkg-fa9200b6-dev-746674cf2387bd406cd7ad55fab95a1986f67d91-pr-26/index.html https://ci-tests.linuxserver.io/lspipepr/fedora/38-38-pkg-fa9200b6-dev-746674cf2387bd406cd7ad55fab95a1986f67d91-pr-26/shellcheck-result.xml	Tag	Passed
amd64-38-38-pkg-fa9200b6-dev-746674cf2387bd406cd7ad55fab95a1986f67d91-pr-26	✅
arm64v8-38-38-pkg-fa9200b6-dev-746674cf2387bd406cd7ad55fab95a1986f67d91-pr-26	✅

LinuxServer-CI commented 1 year ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/fedora/38-38-pkg-b72f7f84-dev-3f211de23de4a58dac94ef7a6165253181e0da78-pr-26/index.html https://ci-tests.linuxserver.io/lspipepr/fedora/38-38-pkg-b72f7f84-dev-3f211de23de4a58dac94ef7a6165253181e0da78-pr-26/shellcheck-result.xml	Tag	Passed
amd64-38-38-pkg-b72f7f84-dev-3f211de23de4a58dac94ef7a6165253181e0da78-pr-26	✅
arm64v8-38-38-pkg-b72f7f84-dev-3f211de23de4a58dac94ef7a6165253181e0da78-pr-26	✅

LinuxServer-CI commented 1 year ago

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

LinuxServer-CI commented 1 year ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/fedora/38-38-pkg-4de5781f-dev-c2b32828278063ffd3cc42ede8c03c5aa19e73a6-pr-26/index.html https://ci-tests.linuxserver.io/lspipepr/fedora/38-38-pkg-4de5781f-dev-c2b32828278063ffd3cc42ede8c03c5aa19e73a6-pr-26/shellcheck-result.xml	Tag	Passed
amd64-38-38-pkg-4de5781f-dev-c2b32828278063ffd3cc42ede8c03c5aa19e73a6-pr-26	✅
arm64v8-38-38-pkg-4de5781f-dev-c2b32828278063ffd3cc42ede8c03c5aa19e73a6-pr-26	✅