LinuxServer-CI
commented
2 months ago | I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/beets/nightly-03f12056-pkg-3ff7db08-dev-2cfc4d2a9182a1b791e79b384ae6144e6349f398-pr-125/index.html https://ci-tests.linuxserver.io/lspipepr/beets/nightly-03f12056-pkg-3ff7db08-dev-2cfc4d2a9182a1b791e79b384ae6144e6349f398-pr-125/shellcheck-result.xml | Tag | Passed |
|---|---|---|
| amd64-nightly-03f12056-pkg-3ff7db08-dev-2cfc4d2a9182a1b791e79b384ae6144e6349f398-pr-125 | ✅ | |
| arm64v8-nightly-03f12056-pkg-3ff7db08-dev-2cfc4d2a9182a1b791e79b384ae6144e6349f398-pr-125 | ✅ |
Description:
With the release of Beets 2.0 around 4 months ago, the builds of Beets in this container spit out an error message upon each album import. The details of this are outlined in #120
As stated in the official documentation for the Discogs plugin, the previous required package for Discogs plugin support (
discogs-client) has been deprecated and superseded bypython3-discogs-client. In order forpython3-discogs-clientto work as intended and not cause Beets to crash withModuleNotFoundError: No module named 'typing_extensions'upon invocation, the packagetyping-extensionshas also been added to the pip install command in both Dockerfiles.Benefits of this PR and context:
This patch, along with another that targets the stable branch, closes #120. Eliminating the error message mentioned in that bug report and furthering working Discogs metadata support for the foreseeable future.
How Has This Been Tested?
The changes in this PR have been tested by locally building the container on my Ubuntu 24.04.1 LTS server and running it with Docker version 27.2.0. The webUI was tested for functionality and, using the CLI interface, multiple albums were imported and edited with my personal Beets configuration file that makes use of the Discogs plugin. All systems functioned as expected sans the aforementioned error.
Source / References: