search

linuxserver / docker-emby

GNU General Public License v3.0
120 stars 40 forks source link

Add support for MediaInfo plugin on amd64 #65

Closed DaveO16176 closed 1 year ago

DaveO16176 commented 1 year ago

linuxserver.io

Description:

Added MediaInfo, MKVToolNix and the BIF file creation tool to the amd64 dockerfile.

Benefits of this PR and context:

Allows a user with Emby on amd64 to utilize the MediaInfo plugin. The plugin's current solution requires the user to install MediaInfo, MKVToolNix and the BIF tool on the base operating system and then call them from the Emby container-{https://github.com/Cheesegeezer/MediaInfoWiki/wiki/Various-OS-Installation-Help#5-docker}. The new dockerfile includes these applications within the docker container and enables full functionality of the MediaInfo plugin.

How Has This Been Tested?

Built the docker container on and amd64 and tested in on and amd64 platform running Ubuntu 20.04. Emby was started and the plugin ran. All media tags were updated. Emby must have write priviliges to all media files for the plugin to run correctlly.

Source / References:

None.

LinuxServer-CI commented 1 year ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/emby/4.7.10.0-pkg-234909be-pr-65/index.html https://ci-tests.linuxserver.io/lspipepr/emby/4.7.10.0-pkg-234909be-pr-65/shellcheck-result.xml

Roxedus commented 1 year ago

This fits better as a mod, especially if it's truly amd64 only

aptalca commented 1 year ago

See comment on #64

github-actions[bot] commented 1 year ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.