linuxserver / docker-pyload-ng

GNU General Public License v3.0
83 stars 10 forks source link

Add environment variable for changing the web interface port #11

Closed ispiropoulos closed 2 years ago

ispiropoulos commented 2 years ago

linuxserver.io


Desired Behavior

Being able to change the default http access port (8000 to something else)

Current Behavior

Cannot change it via environment variable

Alternatives Considered

github-actions[bot] commented 2 years ago

Thanks for opening your first issue here! Be sure to follow the bug or feature issue templates!

aptalca commented 2 years ago

You can map it to a different port. No need to change the internal port.

ispiropoulos commented 2 years ago

You can map it to a different port. No need to change the internal port.

HI and thank you for the response. I know I can map it on a different port. I want to use this container on shared docker network where another container is using this port, and for some reasons I do not want to change it.

Roxedus commented 2 years ago

Fwiw a shared docker network would not give you issues

aptalca commented 2 years ago

I'm assuming they mean pyload is using another container's network (likely for vpn). If so, it's an edge case so I'm not in favor of adding it as a feature globally, however, you can edit the pyload config file in the config folder.

This is the line you're looking for: https://github.com/linuxserver/docker-pyload-ng/blob/main/root/defaults/pyload.cfg#L42 And this is where it gets copied to: https://github.com/linuxserver/docker-pyload-ng/blob/main/root/etc/cont-init.d/30-config#L10-L12

ispiropoulos commented 2 years ago

Fwiw a shared docker network would not give you issues

I guess I have made a mistake with my description above.

I am using a particular container as a network service, and all the containers under it have this network configuration:

network_mode: service:servicecontainer
    depends_on:
      - servicecontainer

Then, another container under that same stack is already using internally port 8000. On my setup, I have mapped ports of the nested containers on the parent servicecontainer, so internal 8000 is mapped already (on a different host port) but it is used from the other container

ispiropoulos commented 2 years ago

I'm assuming they mean pyload is using another container's network (likely for vpn). If so, it's an edge case so I'm not in favor of adding it as a feature globally, however, you can edit the pyload config file in the config folder.

This is the line you're looking for: https://github.com/linuxserver/docker-pyload-ng/blob/main/root/defaults/pyload.cfg#L42 And this is where it gets copied to: https://github.com/linuxserver/docker-pyload-ng/blob/main/root/etc/cont-init.d/30-config#L10-L12

Thank you @aptalca this was exactly the case. Also congratulations for the wide variety of containers! I am actively using Plex, pyload, transmission and others :)

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.